casbin-cpp icon indicating copy to clipboard operation
casbin-cpp copied to clipboard

[PyCasbin-on-CPP] replace some PyCasbin code with Casbin-CPP to improve PyCasbin's performance

Open hsluoyz opened this issue 4 years ago • 4 comments

See: https://github.com/casbin/pycasbin/issues/225

hsluoyz avatar Nov 27 '21 12:11 hsluoyz

@EmperorYP7 @divy9881 @noob20000405 @sheny1xuan

casbin-bot avatar Nov 27 '21 12:11 casbin-bot

@Abingcbc will work on the PyCasbin part.

@sheny1xuan will work on the Casbin-CPP part.

Please work together.

hsluoyz avatar Nov 27 '21 12:11 hsluoyz

This is going to be interesting!

But, I think pycasbin-on-cpp can be a standalone library to be used directly by the client. In other words, how about we try to make this library self-sufficient? It is indeed possible for us to integrate cpp’s pycasbin into pycasbin, but I think of no scope other than that of utility. What do you think about this @sheny1xuan @Abingcbc?

EmperorYP7 avatar Nov 27 '21 17:11 EmperorYP7

@EmperorYP7 I think a standalone lib on pip is also great! Users will not face any breaking change with our version upgrade then. We need to make sure the API between pip's casbin and pycasbin-on-cpp are the same.

hsluoyz avatar Nov 28 '21 01:11 hsluoyz

As https://github.com/casbin/casbin-cpp/issues/174 has fixed this issue, could we close it to avoid confusion?

zhenglin-charlie-li avatar Jan 06 '23 01:01 zhenglin-charlie-li