Casbin.NET icon indicating copy to clipboard operation
Casbin.NET copied to clipboard

feat: Benchmark with more realistic data

Open Leonardo-Ferreira opened this issue 3 years ago • 6 comments

The original benchmark for RBAC With Cache was a bit unrealistic because the same user and the same data was always requested, which is a highly cache-able scenario. By introducing a little variance on the the user and data actually enforced, we can see a MAJOR skew on large datasets but NOT on the smaller ones (this proves that the "randomization" is not the actual at-fault for the performance drop)

Leonardo-Ferreira avatar Feb 15 '22 03:02 Leonardo-Ferreira

@sagilio @xcaptain @huazhikui please review

casbin-bot avatar Feb 15 '22 03:02 casbin-bot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 5 committers have signed the CLA.

:white_check_mark: hsluoyz
:white_check_mark: sagilio
:white_check_mark: Leonardo-Ferreira
:x: apiscevs
:x: dviry
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 15 '22 03:02 CLAassistant

It is a great point. But the old benchmark is synced from the go casbin repo, it is better to use a new file like EnforcerWithCacheRandomBenchmark.cs

sagilio avatar Feb 18 '22 17:02 sagilio

@Leonardo-Ferreira plz fix:

image

hsluoyz avatar Feb 19 '22 01:02 hsluoyz

@hsluoyz this error happens because I cannot read the repos secret. If you look at the activity, it has successfully analyzed the code, but failed at the step of uploading the report due to a invalid key (it was not replaced). This issue is being fixed on a separate PR

Leonardo-Ferreira avatar Feb 22 '22 13:02 Leonardo-Ferreira

@sagilio

hsluoyz avatar Feb 24 '22 01:02 hsluoyz