kapp-controller icon indicating copy to clipboard operation
kapp-controller copied to clipboard

Bump the API version for the packaging APIs and Apps

Open ewrenn8 opened this issue 4 years ago • 2 comments

Describe the problem/challenge you have All of the CRs provided by kapp-controller are currently versioned v1alpha1. According to the k8s API versioning guidelines, they should all actually be versioned v1beta1.

Describe the solution you'd like Bump the api versions to v1beta1 to better align with k8s versioning practices

Anything else you would like to add: No


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible" 👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

ewrenn8 avatar Jul 07 '21 17:07 ewrenn8

Something to consider here is how we would/how long we would support v1alpha1 versions of the CRS.

This would also require us to look into kubebuilder directives for generating the YAML representation of the CRDs with multiple versions (e.g. https://github.com/vmware-tanzu/carvel-kapp-controller/blob/a2236fb3c56c014a8ca10ce422208e45d21229e1/config/crds.yml#L13).

danielhelfand avatar Jul 12 '21 14:07 danielhelfand

Just adding some documentation here on how k8s recommends to think about versioning CRDs: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/

In general, the kapp-controller resources that exist seem to meet v1beta1 requirements. We just need to prioritize this issue and pick the right time to make the switch.

danielhelfand avatar Jan 31 '22 17:01 danielhelfand