python-intermediate-development icon indicating copy to clipboard operation
python-intermediate-development copied to clipboard

Correct inconsistent function name usage in code refactoring exercise

Open matt-graham opened this issue 7 months ago • 2 comments

Fixes #466

Changes usages of compute_standard_deviation_by_data for function name to compute_standard_deviation_by_day to be consistent with earlier exercise. Between compute_standard_deviation_by_data and compute_standard_deviation_by_day the latter seemed the more descriptive of what the function computes and so the better to standardise on.

matt-graham avatar Jun 24 '25 15:06 matt-graham

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • :dart: correct output
  • :framed_picture: correct figures
  • :question: new warnings
  • :bangbang: new errors

Rendered Changes

:mag: Inspect the changes: https://github.com/carpentries-incubator/python-intermediate-development/compare/md-outputs..md-outputs-PR-471

The following changes were observed in the rendered markdown documents:

 34-code-refactoring.md | 6 +++---
 md5sum.txt             | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2025-06-24 15:50:24 +0000

github-actions[bot] avatar Jun 24 '25 15:06 github-actions[bot]

Good idea, and as we don't have any branches for 3.4+ in the example repo, this doesn't imply any extra work.

smangham avatar Oct 09 '25 15:10 smangham