python-intermediate-development icon indicating copy to clipboard operation
python-intermediate-development copied to clipboard

Update 24-diagnosing-issues-improving-robustness.md

Open jreeve-nv opened this issue 1 year ago • 1 comments

Corrected error where the automating pylint section creates a branch named pylint-ci but then merges test-suite back into develop. Now the merge back into develop is with the pylint-ci branch.

jreeve-nv avatar Aug 29 '24 00:08 jreeve-nv

Likely related to #365

bielsnohr avatar Aug 29 '24 10:08 bielsnohr

Also related to #383, which appears to have a different solution to the same issue if I understand it correctly. After discussing it with Aleks, we'll need to work out the best way forward after the material has transitioned to the new format which has become a priority. We'll recreate the PR after that. At least we're not short on solutions for this :)

steve-crouch avatar Oct 03 '24 11:10 steve-crouch

Thanks for the contribution @jreeve-nv and comments @steve-crouch

As I detailed in this comment, this is actually solved if we just get rid of creation and mention of the pylint-ci branch and continue working on the test-suite branch that learners should already be on at this point in the lesson. I have done a search through the lesson material, and there is no other reference to pylint-ci anywhere else in the lesson, so this should be a safe change with no knock-on effects.

@jreeve-nv I have pushed updates to your PR to reflect these comments. Will wait for another member of the maintainer team to approve before we go ahead and merge.

bielsnohr avatar Oct 21 '24 17:10 bielsnohr

Thanks for the contribution @jreeve-nv and comments @steve-crouch

As I detailed in this comment, this is actually solved if we just get rid of creation and mention of the pylint-ci branch and continue working on the test-suite branch that learners should already be on at this point in the lesson. I have done a search through the lesson material, and there is no other reference to pylint-ci anywhere else in the lesson, so this should be a safe change with no knock-on effects.

@jreeve-nv I have pushed updates to your PR to reflect these comments. Will wait for another member of the maintainer team to approve before we go ahead and merge.

Let's have a chat about this @bielsnohr next time we meet later this week - I am actually minded to have this work on a separate branch pylint-ci and then merge that branch onto develop branch at the end of the episode to reinforce the feature-branch development workflow.

anenadic avatar Oct 22 '24 15:10 anenadic