gitmoji-cli icon indicating copy to clipboard operation
gitmoji-cli copied to clipboard

Feature/add commit extra args

Open vinicius73 opened this issue 4 years ago • 4 comments

Description

Allow defining extra arguments to be used in every commit.

Issue: #

Tests

  • [x] All tests passed.

vinicius73 avatar Mar 03 '22 14:03 vinicius73

Hi @carloscuesta, can you check it?

vinicius73 avatar Mar 08 '22 20:03 vinicius73

Hey we already discussed a similar implementation of this into #192 can you explain the use-case of the arguments that you want to pass?

carloscuesta avatar Mar 12 '22 09:03 carloscuesta

Hi @carloscuesta, thanks to answer.

Now a days I must use --signoff in all of my commits.

I use gitmoji-cli every time, but I can't add --signoff using it.

vinicius73 avatar Mar 12 '22 12:03 vinicius73

I see, curious why you use the sign-off but not actually signing commits with a verified GPG key. I feel that adding extraArgs would make the cli more prone to errors but actually not covering them can make people opt out of using the cli for the same reason 😓

I think we need to find a solution where we can automatically forward the unknown parameters to the underlying git command so we don't have to write any extra code

Something like this

gitmoji -c -- -signoff

carloscuesta avatar Mar 15 '22 18:03 carloscuesta

Hey @vinicius73 I'll close this PR as you can setup the way git signs off commits in your global .gitconfig

Thanks! 🙏🏼

carloscuesta avatar Aug 20 '22 10:08 carloscuesta