capstone icon indicating copy to clipboard operation
capstone copied to clipboard

Fix the 0x66 preffix handling for JMP, Jcc CALL for intel

Open n80fr1n60 opened this issue 7 years ago • 7 comments

n80fr1n60 avatar Mar 01 '18 18:03 n80fr1n60

I already submitted a fix #1010 but for whatever reason the developers didn't answer me. I wish you the best of luck.

krystalgamer avatar Mar 04 '18 23:03 krystalgamer

please resolve the conflicts and rebase to 4.1

radare avatar Jan 22 '19 09:01 radare

@radare why are you commenting 1 year later? This PR does not fix the issue and the creator most definitely won't rebase this.

krystalgamer avatar Jan 24 '19 20:01 krystalgamer

Yeah, sometimes i also wonder why i care about things no one else do

radare avatar Jan 24 '19 20:01 radare

@krystalgamer This PR does not fix the issue and the creator most definitely won't rebase this. ---> mind adding op codes where this does not work ? ---> interesting , why do you know I will not rebase ???

n80fr1n60 avatar Jan 25 '19 14:01 n80fr1n60

@n80fr1n60 No I won't add shit. By helping you it'd mean I'd be contributing to this garbage disassembler.

Lastly, due to your low github activity I suspected you had moved on, you can do whatever you want, but still I just wanted to tell one of the developers directly that pilling PR without answering is just plain retarded. After so long without answers and such low activity on this repo, it's clear the creator just wants to grow his e-peen.

Don't believe me? Just check the showcases page: http://www.capstone-engine.org/showcase.html The creator goes around github asking for credits left and right and doesn't do shit with others contributions. My project and x64dbg are still there even though both have dropped capstone a long time ago.

krystalgamer avatar Jan 25 '19 21:01 krystalgamer

Can you please create a new PR on libcapstone?

pranith avatar Mar 04 '21 07:03 pranith

Thank you for the PR! I closed it because it is out of date. With the new auto-sync update for v6 we made many changes to some main architectures and will do also to others. This also changed the requirements we have now for new PRs.

If you still want to merge the changes, please rebase your fix onto the newest next branch and open a new PR.

Rot127 avatar Mar 20 '24 09:03 Rot127