sshkit icon indicating copy to clipboard operation
sshkit copied to clipboard

skip whoami check in as command

Open abhishiv opened this issue 6 years ago • 4 comments

ref #470

abhishiv avatar Jul 30 '19 08:07 abhishiv

2 Warnings
:warning: There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.
:warning: Please update CHANGELOG.md with a description of your changes. If this PR is not a user-facing change (e.g. just refactoring), you can disregard this.

Here's an example of a CHANGELOG.md entry (place it immediately under the * Your contribution here! line):

* [#471](https://github.com/capistrano/sshkit/pull/471): skip whoami check in as command - [@abhishiv](https://github.com/abhishiv)

Generated by :no_entry_sign: Danger

capistrano-bot avatar Jul 30 '19 09:07 capistrano-bot

Can you clarify exactly why you want to introduce this please?

Another configuration option also needs docs and an explanation of why this exists and why we might need it.

SSHKit has existed for six years without this bypass and only two people have ever raised issue with the way it is designed. (and I know for a fact that many people, my clients included) run Capistrano via SSHKit with restricted user accounts.

I'd love to understand more about your use-case before taking a general solution.

Thanks for taking the time to submit a PR.

leehambley avatar Jul 30 '19 09:07 leehambley

Hey @leehambley

I think the issue is that many distributions(like ubuntu on scaleaway) come without sudo. Hence it requires first to install sudo using apt before you can use sshkit.

Hence I think it's make more sense to remove this check. Is there a specific rationale that you want to keep this check for?

abhishiv avatar Jul 30 '19 10:07 abhishiv

Applied "stale" label, will close in a few weeks if still stale.

leehambley avatar Jan 05 '21 17:01 leehambley