electron icon indicating copy to clipboard operation
electron copied to clipboard

using HTTPS protocol for Strict-Transport-Security reason

Open calvinckho opened this issue 5 years ago • 6 comments

Describe the bug Embedding Stripe.js integration requires HTTPS as the security protocol. Right now the base url is capacitor-electron://.

To Reproduce

  1. install nix-stripe
  2. Compile the app and run in Electron

Expected behavior Use https:// as the security protocol instead of capacitor-electron:// so I can use Stripe.js in my app.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Electron on macOS. @capacitor-community/electron-core

calvinckho avatar Aug 13 '20 23:08 calvinckho

Is there a way to override the protocal name? createCapacitorElectronDeepLinking(myCapacitorApp, { customProtocol: 'myapp://dev' }); I have tried the above but no effect.

bhagavan44 avatar Aug 14 '20 19:08 bhagavan44

Unfortunately, the given link is dead


From: Corey Vaillancourt [email protected] Sent: Saturday, August 15, 2020 1:53:28 AM To: capacitor-community/electron [email protected] Cc: Bhagavan Reddy [email protected]; Comment [email protected] Subject: Re: [capacitor-community/electron] using HTTPS protocol for Strict-Transport-Security reason (#48)

For things like deep linking you can set a custom protocol per the docs here: https://rocketdocs.netlify.com/usage/deeplinking

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/capacitor-community/electron/issues/48#issuecomment-674257683, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABKRRWGBA25HXGVHRYERU43SAWMMBANCNFSM4P66NUFA.

bhagavan44 avatar Aug 14 '20 20:08 bhagavan44

Is there a way to override the protocal name? createCapacitorElectronDeepLinking(myCapacitorApp, { customProtocol: 'myapp://dev' }); I have tried the above but no effect.

This is for deeplinking and not what the issue is referring to.

IT-MikeS avatar Aug 17 '20 04:08 IT-MikeS

Describe the bug Embedding Stripe.js integration requires HTTPS as the security protocol. Right now the base url is capacitor-electron://.

To Reproduce

  1. install nix-stripe
  2. Compile the app and run in Electron

Expected behavior Use https:// as the security protocol instead of capacitor-electron:// so I can use Stripe.js in my app.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Electron on macOS. @capacitor-community/electron-core

Interesting, I will look into this and have to get back to you on that

IT-MikeS avatar Aug 17 '20 04:08 IT-MikeS

Is there a way to override the protocal name? createCapacitorElectronDeepLinking(myCapacitorApp, { customProtocol: 'myapp://dev' }); I have tried the above but no effect.

This is for deeplinking and not what the issue is referring to.

I don't need the deep linking, but in the docs I saw the custom protocol and thought it will change the protocol. All I need is a way to change the protocol from default one.

bhagavan44 avatar Aug 17 '20 06:08 bhagavan44

FYI: Similar issue if you are using FirebaseUI login - it also expects http or https protocol for most login providers.

Also I just ran into another issue when migrating from an electron app to a capacitor-electron app. Since I used file:// protocol before, anything stored in localStorage/IndexedDB will not be accessible because the protocol is changed.. :/

tillbaks avatar Sep 03 '20 11:09 tillbaks