Added module teardown

Open chriskinsman opened this issue 10 years ago • 2 comments

Module teardown to allow closing out connection pools, etc so that nodeunit exit expeditiously after running tests

Apr 24 '15 16:04 chriskinsman

Any chance of getting this merged or is there a philosophical reason to not do this?

Happy to go another route and/or eliminate the pull request @mreinstein

Thanks!

Dec 27 '16 16:12 chriskinsman

I would love to see this PR merged. We have had to do some massive hacks to get similar behavior in our tests.

My guess is that because this project is not active any more, there is no one available who can spend time reviewing this PR.

So, I'll review it myself, even though I am not a committer on this project. Maybe we can push this forward. Some suggestions:

moduleTearDown should run even if there is an error.
It should also be wrapped in a try/catch block
Why are you deleting moduleTearDown from the suite?
A similar moduleSetUp function would be very useful as well, but should probably go in a different PR.

Jun 02 '17 03:06 aeisenberg