Add application layout components

Open huwshimi opened this issue 2 years ago • 4 comments

Creating this draft in case anyone is planning to do something similar. I haven't had time to finish this, but these components are used in Juju Dashboard and ReBAC Admin.

TODO

[x] Update imports
[ ] Add docs
[x] Update tests to work in react-components
[x] Export components and types

Jan 24 '24 22:01 huwshimi

Demo starting at https://react-components-1031.demos.haus

Jan 24 '24 22:01 webteam-app

I made just a rough review of the Panel and SideNavigation components. Maybe factor them into a dedicated PR to make it easier to review? I think those two are a bit more controversial and might need more detailed alignment and discussions.

That's a good idea, I might split this up into a number of PRs once I have it all working together.

May 13 '24 06:05 huwshimi

This PR is being prevented from merging because it needs to be reviewed on Percy.

Go to Percy, find the build relevant to this PR and check if it looks as expected.

Once it's approved, add the label Review: Percy +1 to this PR.

May 14 '24 06:05 github-actions[bot]

Here are some tests I've conducted to see how these components would work in our apps:

https://github.com/canonical/lxd-ui/pull/768 https://github.com/canonical/identity-platform-admin-ui/pull/309 https://github.com/canonical/maas-ui/pull/5434 https://github.com/canonical/juju-dashboard/pull/1752 https://github.com/canonical/rebac-admin/pull/106

May 15 '24 04:05 huwshimi

This has been split up:

https://github.com/canonical/react-components/pull/1090
https://github.com/canonical/react-components/pull/1089
https://github.com/canonical/react-components/pull/1088

May 17 '24 05:05 huwshimi