VMware: to move customization from datasource OVF to datasource VMware

[PengpengSun]

Proposed Commit Message

summary: VMware: Move Guest Customization transport from OVF to VMware

This change is moving VMware Guest Customization data transport to VMware datasource,
the goal is to have a single datasource for VMware which is named DatasourceVMware.
Besides Guest Customization data transport(by local file), VMware datasource already
has other data transports, like Guestinfo Keys and environment arguments.

The detailed changes are:
1. Remove Guest Customization data transport from OVF datasource.
2. Refactor Guest Customization data transport code and add them to VMware datasource,
   For backward compatibility, Guest Customization data transport is put ahead of the
   other existing data transport since OVF is ahead of VMware in datasource searching
   list.
3. Add instance-id support in customization configuration file, so that instance-id
   can be given from vSphere side, if instance-id is not given, this datasource will
   read it from the file /sys/class/dmi/id/product_uuid no matter what transport is.
4. Move Guest Customization detection from dscheck_OVF() to dscheck_VMmare() in
   ds_identify script, Guest Customization detection is ahead of the other existing
   data transports since OVF is ahead of VMware in datasource searching list.
5. Modify unittests according to above changes.
6. Modify both OVF and VMware datasource documents according to above changes.
7. Guestinfo OVF data transport is left to OVF datasource since it uses OVF which is
   same with iso9660 transport.

If you need to write multiple paragraphs, feel free.

LP: #NNNNNNN (replace with the appropriate bug reference or remove
this line entirely if there is no associated bug)

Additional Context

Test Steps

Checklist:

• [x] My code follows the process laid out in the documentation
• [x] I have updated or added any unit tests accordingly
• [x] I have updated or added any documentation accordingly

[github-actions[bot]]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

[PengpengSun]

Hi @TheRealFalcon

Could someone from cloud-init team help to take a look this PR, thanks! This is mainly a Datasource VMware related change and I've also requested my colleagues include @akutz to help to review this change.

Best regards, Pengpeng

[akutz]

It's on my queue. It happened right before I went on PTO, and apparently it takes me two weeks to catch up from being off a week.

I'll try to take a look tomorrow.

[github-actions[bot]]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

[PengpengSun]

Not all comments from Andrew have been addressed, working on this PR.

[PengpengSun]

Hi @akutz , Thanks for the review. I probably addressed all your comments, please take another look at this.

[github-actions[bot]]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

[PengpengSun]

Ping. Hi @akutz , please take another look at this, thanks.

[akutz]

Hi @PengpengSun,

For backward compatibility, Guest Customization data transport is put ahead of the other existing data transport since OVF is ahead of VMware in datasource searching list.

Is this still true? From the PR it looks like IMC is put after the other methods? Also, it might be nice if it was due to https://bugs.launchpad.net/cloud-init/+bug/1992509.

[PengpengSun]

For backward compatibility, Guest Customization data transport is put ahead of the other existing data transport since OVF is ahead of VMware in datasource searching list.

Is this still true? From the PR it looks like IMC is put after the other methods? Also, it might be nice if it was due to https://bugs.launchpad.net/cloud-init/+bug/1992509.

I've changed the IMC to be the last one in DS VMware, but I’m afraid that this can NOT resolve the issue https://bugs.launchpad.net/cloud-init/+bug/1992509. The ISO transport is still left in DS OVF which I think is the transport used in the issue.

[TheRealFalcon]

@akutz , do you plan on another round of review here, or should I take it?

@PengpengSun , if aktuz doesn't rereview, are you comfortable with me reviewing without him?

[akutz]

@akutz , do you plan on another round of review here, or should I take it?

@PengpengSun , if aktuz doesn't rereview, are you comfortable with me reviewing without him?

I will take another look.

[github-actions[bot]]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

[PengpengSun]

Hi @akutz , I've just updated all product document and programming guide links to the latest vSphere 8.0 version in vmware.rst.

[akutz]

Hi @TheRealFalcon ,

Can you please re-open this PR? I apologize for the tardy review. Life got in the way.

[PengpengSun]

@akutz @TheRealFalcon Much appreciate your help on this PR!