cboe icon indicating copy to clipboard operation
cboe copied to clipboard
verified publisher icon calref

First round of fixes for XML errors, there may be more

Open seisatsu opened this issue 5 years ago • 1 comments

This should fix all errors relating to the led element missing a width attribute, as well as the "neg pos" issue in edit-party.xml. I'll keep pushing files as I fix them.

seisatsu avatar Mar 17 '20 00:03 seisatsu

Thanks for the pull request! I want to review each of these cases in more detail though, so I'll hold off on merging it until I have some more time. Setting width to 14 is definitely the correct answer in some of those cases, but I think there are at least a few where it makes more sense to take the width from an associated <text> and move its contents into the <led> (thus deleting the <text>). Might also require repositioning the <led> (probably using the <text>'s location).

CelticMinstrel avatar Mar 17 '20 00:03 CelticMinstrel

This pull request is obsolete now, as LEDs no longer require a width attribute if they have no content. That said, there's the argument that many of these LEDs should have content, at which point they would need to have a width as well.

(The other change in this PR, not related to width, was already fixed manually in master.)

CelticMinstrel avatar Jan 06 '23 08:01 CelticMinstrel