reassure icon indicating copy to clipboard operation
reassure copied to clipboard

example: add CRA

Open mdjastrzebski opened this issue 3 years ago • 5 comments

mdjastrzebski avatar Jun 21 '22 10:06 mdjastrzebski

⚠️ No Changeset found

Latest commit: 1c7270cb36d3ebcd31d3966dd1043c575c949d02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 08 '22 12:07 changeset-bot[bot]

Hey folks.

I fixed up some types for scenarios so that they can support both native and web API without throwing type errors. I also added cleanup to RTL configuration to make sure it runs properly, it looks good.

On other hand - I ran into an issue with global.gc() being unavailable in web. After checking, it is indeed missing in globals even though --expose-gc is added to node script spawn.

Also, reassure seems to be missing after branch switch.

Xiltyn avatar Jul 10 '22 11:07 Xiltyn

Currently blocked by CRA spawning another node process without the flags that we pass:

image

thymikee avatar Jul 15 '22 13:07 thymikee

@thymikee this can be solved by moving node flags from measure CLI to measure code (setup) and using v8.setFlagsFromString.

mdjastrzebski avatar Jul 15 '22 13:07 mdjastrzebski

Performance Comparison Report

Significant Changes To Render Duration

Name Render Duration Render Count
Async Component 208.2 ms → 203.6 ms (-4.6 ms, -2.2%) 7 → 7
Other Component 10 127.9 ms → 122.6 ms (-5.3 ms, -4.1%) 4 → 4
Show details
Name Render Duration Render Count
Async Component Baseline
Mean: 208.2 ms
Stdev: 5.7 ms (2.7%)
Runs: 216 214 214 212 210 206 205 203 202 200

Current
Mean: 203.6 ms
Stdev: 5.8 ms (2.8%)
Runs: 211 211 206 206 204 203 203 201 200 191
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Other Component 10 Baseline
Mean: 127.9 ms
Stdev: 4.5 ms (3.5%)
Runs: 133 133 131 129 129 128 128 127 122 119

Current
Mean: 122.6 ms
Stdev: 7.4 ms (6.1%)
Runs: 132 131 129 127 124 123 120 116 113 111
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Other Component 20 124.5 ms → 124.4 ms (-0.0 ms, ±0.0%) 4 → 4
Other Component 10 legacy scenario 125.6 ms → 124.3 ms (-1.3 ms, -1.0%) 4 → 4
Show details
Name Render Duration Render Count
Other Component 20 Baseline
Mean: 124.5 ms
Stdev: 3.4 ms (2.7%)
Runs: 130 130 129 128 127 125 125 125 125 125 125 125 124 124 122 122 121 120 119 118

Current
Mean: 124.4 ms
Stdev: 7.1 ms (5.7%)
Runs: 142 132 131 131 129 128 127 127 127 125 124 123 122 122 121 117 116 116 115 113
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Other Component 10 legacy scenario Baseline
Mean: 125.6 ms
Stdev: 2.7 ms (2.1%)
Runs: 131 129 127 125 125 125 124 124 124 122

Current
Mean: 124.3 ms
Stdev: 5.2 ms (4.2%)
Runs: 135 132 125 124 124 122 121 120 120 120
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by :no_entry_sign: dangerJS against 1c7270cb36d3ebcd31d3966dd1043c575c949d02

github-actions[bot] avatar Aug 04 '22 10:08 github-actions[bot]

@mdjastrzebski @thymikee What do we wanna do with this one? I assume there is still work to done here or are we dropping this? It's getting pretty stale here and I'm not sure how to handle these hanging bits ;)

Please advise. We gotta start cleaning it all up a bit.

Xiltyn avatar Feb 07 '23 11:02 Xiltyn

@Xiltyn ultimately it would be good to have an example/docs with CRA support. Although CRA is slowly sliding into void, and more people are using things like Vite, however there are potentially a lot of already built complex apps based on CRA, that we could target if we had such example.

mdjastrzebski avatar Feb 08 '23 10:02 mdjastrzebski