reassure icon indicating copy to clipboard operation
reassure copied to clipboard

Fail the CI measure process if jest fails

Open zacharyfmarion opened this issue 3 years ago • 2 comments

Summary

Use the exit code from the jest spawned process to fail the reassure job if jest errors out. Our performance tests were silently failing since jest was failing to properly render the components. See https://github.com/callstack/reassure/issues/171

Test plan

I tested locally by manually throwing an error in a test and running reassure.

zacharyfmarion avatar Sep 19 '22 19:09 zacharyfmarion

🦋 Changeset detected

Latest commit: d07c24aced8793a8876f8f8cda9c900f2fcd7fae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@callstack/reassure-cli Minor
reassure Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 19 '22 19:09 changeset-bot[bot]

@mdjastrzebski thanks for the quick review - addressed feedback!

zacharyfmarion avatar Sep 19 '22 23:09 zacharyfmarion