callstack
Use `ImageURISource` for thumb image instead of `ImageSource` to fix image not loading
This pull request fixes #711
It migrates from ImageSource type from RN to ImageURISource. Those are both from RN and have common props however ImageSource is no longer supported by the v0.79 app (and beyond).
This fix includes both iOS and Android. Also, all dev deps were updated to make sure we have the recent types used within the package when consumed by the app.
Note:: Removing tests from workflow is temporary due to versions update and tests now failing (some features of React test were used previously).
@BartoszKlonowski I wanted to check to see if you have any updates as to when this might be merged and released? We're unable to use a custom thumbImage in newer versions of React Native (e.g. 0.80.2).
@BartoszKlonowski FWIW, I forked the repo and merged the changes here into 5.0.1. It fixes the issue with the iOS thumb image not working 🙏
@brianlenz @Qdafengzi Thank you for the interest and checking the solution!
It's been a while since I had a possibility to sit down to it, but in the meantime, together with @okwasniewski (thanks!) we figured out that what is implemented in this PR is rather a workaround and we should rather stick to ImageSource.
Considering input provided in #734 by @pingkai there is an option to figure out a better solution soon.
I'm hoping for your patience while we'll be pushing the topic forward, and in the meantime please reach out to a workaround suggested in #734.
I will keep this thread active as soon as there will be more findings or ETAs.
Thank you!
