react-native-paper icon indicating copy to clipboard operation
react-native-paper copied to clipboard

fix: bottom navigation shifting={false} active pill display

Open studioromeo opened this issue 3 months ago • 1 comments

Motivation

When the bottom nav has the attribute shifting={false} the pill shape is misformed on the active tabs. On clicking around this seems inconsistent.

This appears to be because the animated view is added / removed as the tab is focused causing the animation to not play or half play. Since it starts at 0.5 scaleX this appears to the user as a squashed pill shape. The intended animation is to expand out from the center.

This commit fixes this by ensuring the animation is always present and simply varies the outputRange of the animation depending on the focused state.

Related issue

https://github.com/callstack/react-native-paper/issues/4819

Test plan

Note: I had failures running the tests on main which i could not resolve so I've had to skip running the tests for this PR however I have run the other yarn checks. Apologies for this and I would appreciate if anyone could run the tests on this.

studioromeo avatar Oct 17 '25 11:10 studioromeo

Hey @studioromeo, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

callstack-bot avatar Oct 17 '25 11:10 callstack-bot