react-native-paper

react-native-paper copied to clipboard

Reame
Issues

fix: input label not visible on ios if multiline, fixes #4482

Open damianfilipek81 opened this issue 1 year ago • 2 comments

Motivation

This PR solves this issue. "When focusing into a TextInput (when mode='flat'), the label disappears. It shows up normally when multiline=false, and this is only a problem on iOS."

Related issue

Test plan

I've checked it on ios simulator and android emulator, since example project is on expo 48 i cannot install it on my phone. I've also updated TextInput.test.tsx.snap snapshot since tests were failing.

Sep 14 '24 21:09 damianfilipek81

Hey @damianfilipek81, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

Sep 14 '24 21:09 callstack-bot

@gedu Is this planned to be merged? Still an issue in 5.12.5.

Oct 07 '24 23:10 iM-GeeKy

@gedu @BogiKay any plans on merging this in now that new arch is supported?

Jan 15 '25 22:01 ericpoulinnz

Worth checking that this PR fixes the issue on web as well. Since I posted the issue (#4482) I found this also is a problem on web.

Jan 26 '25 21:01 ericpoulinnz

@ericpoulinnz I tested it and the issue is gone on web as well

Jan 27 '25 10:01 BogiKay

@BogiKay any chance a new version can be pushed out now that this fixed is merged in?

Mar 18 '25 19:03 ericpoulinnz