react-native-paper icon indicating copy to clipboard operation
react-native-paper copied to clipboard
verified publisher icon callstack

feat(Appbar): use height based on the platform

Open brunohkbx opened this issue 5 years ago • 3 comments

Summary

Appbar is using the wrong height on iOS. This was noticed when using Appbar as a custom header in react-navigation.

This implementation still differs from react-navigation because we aren't checking if the orientation is landscape.

Test plan

  1. Open the example app on iOS
  2. Check if the header has a height of 44px

brunohkbx avatar Oct 15 '20 17:10 brunohkbx

The mobile version of example app from this branch is ready! You can see it here

.

github-actions[bot] avatar Oct 15 '20 17:10 github-actions[bot]

@brunohkbx Thanks for the contribution. Unfortunately, this is a breaking change and we need to wait with this change till the next major version. We will keep it open, cause we definitely want to have it merged when the right time comes.

Trancever avatar Oct 26 '20 11:10 Trancever

Is it possible to work around this with theming or styling?

edit: it was easy to solve this with patch-package

ottob avatar Oct 29 '20 12:10 ottob