react-native-builder-bob icon indicating copy to clipboard operation
react-native-builder-bob copied to clipboard

feat: preserve casing and handle npm namespace scenario

Open wood1986 opened this issue 3 years ago • 3 comments

Summary

For the inputs without namespace and react-native- scenario

yarn exec create-react-native-library WooDLibs
yarn exec v1.22.19
✔ What is the name of the npm package? … wood-libs
✔ What type of library do you want to develop? › Turbo module with backward compat (experimental)

image

For the inputs with namespace scenario

yarn exec create-react-native-library WooDLibs
yarn exec v1.22.19
✔ What is the name of the npm package? … @wood1986/wood-libs
✔ What type of library do you want to develop? › Turbo module with backward compat (experimental)

image

Test plan

wood1986 avatar Jul 04 '22 09:07 wood1986

Before I fix the tests, I want to get your approval

wood1986 avatar Jul 04 '22 09:07 wood1986

ping

wood1986 avatar Aug 10 '22 07:08 wood1986

I'll work on getting this merged tomorrow

satya164 avatar Oct 13 '22 20:10 satya164

I refactored and implemented this in https://github.com/callstack/react-native-builder-bob/commit/4993bc9d200ea235456214f565184d9fd6dcf95f trying to preserve the namespace and spacing while still avoiding invalid input. I have added you as co-author of the commit since it's based on your work. Thanks again for the PR.

satya164 avatar Oct 23 '22 15:10 satya164

Thanks for the merge

wood1986 avatar Oct 24 '22 00:10 wood1986