PointMVSNet icon indicating copy to clipboard operation
PointMVSNet copied to clipboard

Possible problem of Deconv2d

Open MiZhenxing opened this issue 4 years ago • 0 comments

Hi, thank you for your excellent code.

Maybe there is a problem in the forward function of Deconv2d, not causing problems in corrent code.

https://github.com/callmeray/PointMVSNet/blob/cacb2d719bac4f8ed63f9cdd9d6e91b01c991077/pointmvsnet/nn/conv.py#L158-L167

The Line 164 assign self.bn(y) to x, and the Line 166 use x as input. So if self.bn is None, then the input of Line 166 will not be y, but be the very original x. So the Deconv2d will only be equivalent to a relu function if we set self.bn to None. A same problem is also in Deconv3d. This bug dose not cause any problem in the method when we all use bn. This issue is just for discussion.

Thank you very much.

MiZhenxing avatar May 25 '21 13:05 MiZhenxing