react-live-chat-loader icon indicating copy to clipboard operation
react-live-chat-loader copied to clipboard

refactor: improve TypeScript definitions

Open tien opened this issue 3 years ago • 2 comments

This PR fixes the following TypeScript issues:

  • LiveChatLoaderProvider not accepting multiple children, fixed by typing children as ReactNode instead of JSX.Element
  • Messenger component required explicitly passing providerKey prop like so <Messenger providerKey={undefined} />
  • missing optional locale prop on LiveChatLoaderProps used by Facebook Messenger

tien avatar Sep 21 '22 04:09 tien

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 21 '22 04:09 CLAassistant

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-live-chat-loader ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 4:34AM (UTC)

vercel[bot] avatar Sep 21 '22 04:09 vercel[bot]

Hey @tien, thanks for this. We recently updated TS types (see release 2.8.0) so this PR is no longer applicable. All the same, thanks for your contribution here. 💫

benschwarz avatar Oct 26 '22 01:10 benschwarz