calcom
fix: Hidden event type switch behaviour is out of sync between event types page & single view
Fixes #8766
Task Description
https://www.figma.com/file/xk4HOxtSI82J0F7enMxeak/2.-Cal---Live?type=design&node-id=4654%3A167842&t=eOPD3fNaNM4CMyZS-1
Loom video
https://www.loom.com/share/cc342bb949cf452aad7419f1d91858f7
CAL-1634 Hidden event type switch behaviour is out of sync between event types page & single view
https://github.com/calcom/cal.com/assets/8019099/70281914-132a-4c7c-9ce2-f68462835087
When I toggle an event type as hidden on the event types page, the opposite behaviour appears when I click in to view the single event type. When I then toggle it in the single view and come back out, it seems to toggle the complete opposite behaviour by itself on the event types page.
![linear[bot] avatar](https://avatars.githubusercontent.com/in/20150?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 30, 2023 3:13pm |
| ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 30, 2023 3:13pm |
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| api | ⬜️ Ignored (Inspect) | Visit Preview | May 30, 2023 3:13pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Current Playwright Test Results Summary
✅ 104 Passing - ⚠️ 5 Flaky
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 05/30/2023 03:34:58pm UTC)
Run Details
Running Workflow PR Update on Github Actions
Commit: efeabc39ef1ece691a7fe3b1a979260ca4e5d37d
Started: 05/30/2023 03:30:28pm UTC
⚠️ Flakes
📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
1.35% (5)5 / 371 runsfailed over last 7 days |
20.22% (75)75 / 371 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to disable 2FA
Retry 1 • Initial Attempt |
0% (0)0 / 21 runsfailed over last 7 days |
4.76% (1)1 / 21 runflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- old-booker can add multiple organizer address
Retry 1 • Initial Attempt |
2.33% (9)9 / 387 runsfailed over last 7 days |
6.20% (24)24 / 387 runsflaked over last 7 days |
📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt |
0% (0)0 / 34 runsfailed over last 7 days |
11.76% (4)4 / 34 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
2.80% (4)4 / 143 runsfailed over last 7 days |
65.03% (93)93 / 143 runsflaked over last 7 days |
![deploysentinel[bot] avatar](https://avatars.githubusercontent.com/in/210057?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @Jaibles, please review the PR
@gitstart can you please update the loom link. It's a demo of something from an app called Spellbound.
@gitstart can you please update the loom link. It's a demo of something from an app called Spellbound.
Sorry about that 😅 Updated the link now
Hi @leog, now that you mentioned it, we missed updating the switch behavior in the menu in Single Event Types. We are going to fix that and add the switch in the menu in the Event Types as well.
Hi @leog, now that you mentioned it, we missed updating the switch behavior in the menu in Single Event Types. We are going to fix that and add the switch in the menu in the Event Types as well.
cool. will wait for the change before merging
HI @leog, we have updated the PR, please re-review. cc: @Jaibles @PeerRich