cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard
verified publisher icon calcom

Eventhough, After updation of Appearance Theme. Update button is still enabled

Open VinoV1999 opened this issue 2 years ago • 1 comments

Issue Summary

Eventhough Appearance theme is update. The update button is still enabled and disabled when we try to select the previous theme.

https://github.com/calcom/cal.com/assets/123581387/555ea77b-2814-4e83-8318-00bb92d94aa0

Steps to Reproduce

  1. Went to Settings -> Appearance.
  2. Update theme.
  3. select the previous theme.

Once we updated, update button should be disable and only enables when changes occurs.

VinoV1999 avatar May 23 '23 15:05 VinoV1999

@hariombalhara I already fixed this issue. kindly assign the bug to me if it's approved.

VinoV1999 avatar May 23 '23 15:05 VinoV1999

can you assign this to me

NischalGautam8 avatar May 24 '23 01:05 NischalGautam8

Hi @headshigh, sorry to inform u that. I had the fix in my local. Kindly look for other issues :)

VinoV1999 avatar May 24 '23 02:05 VinoV1999

Did you just remove !Isdirty tag from disabled disabled prop of input or were you able to refetch user theme preference once he has made changes and put it on default values?

NischalGautam8 avatar May 24 '23 02:05 NischalGautam8

Isdirty is required to monitor the changes. So I Have reset the default values with the updated values

VinoV1999 avatar May 24 '23 02:05 VinoV1999