cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-115] /getting-started/connected-calendar Toggle the first calendar on

Open asadath1395 opened this issue 2 years ago • 4 comments

What does this PR do?

[CAL-115] /getting-started/connected-calendar Toggle the first calendar on

Fixes #4384

https://github.com/calcom/cal.com/assets/37188392/aa9a0179-a355-464d-84c6-15fde1b07762

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  1. Create a new account
  2. Follow the steps and connect any calendar
  3. You should see the first calendar selected by default

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

asadath1395 avatar May 22 '23 08:05 asadath1395

@asadath1395 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 22 '23 08:05 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 5:36am

vercel[bot] avatar May 22 '23 08:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 255.65 KB 406.86 KB 116.25% (🟡 +0.14%)
/apps/[slug]/[...pages] 458.51 KB 609.72 KB 174.21% (🟢 -0.25%)
/auth/setup 174.51 KB 325.72 KB 93.06% (🟢 -0.16%)
/d/[link]/book 255.29 KB 406.51 KB 116.14% (🟡 +0.15%)
/event-types/[type] 479.08 KB 630.29 KB 180.08% (🟢 -0.18%)
/getting-started/[[...step]] 427.25 KB 578.46 KB 165.27% (🟡 +0.23%)
/new-booker/[user]/[type] 290.84 KB 442.05 KB 126.30% (🟡 +0.14%)
/new-booker/d/[link]/[slug] 290.84 KB 442.05 KB 126.30% (🟡 +0.14%)
/new-booker/team/[slug]/[type] 290.84 KB 442.06 KB 126.30% (🟡 +0.14%)
/settings/my-account/calendars 253.5 KB 404.71 KB 115.63% (🟡 +0.23%)
/team/[slug]/book 255.29 KB 406.51 KB 116.15% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 22 '23 09:05 github-actions[bot]

@CarinaWolli Thank you for taking the time to review the PR. I have fixed error which you raised above and added your suggestion to fix the type error also. Please re-review.

asadath1395 avatar May 23 '23 14:05 asadath1395

@CarinaWolli I have addressed your concern, please re-review. Thanks

asadath1395 avatar May 30 '23 07:05 asadath1395