[CAL-1728] confirmation mail: booking questions uses identifier not label

[PeerRich]

_CAL-1728

[PeerRich]

emails (everywhere in general) should use label and not identifier

[gitstart-app[bot]]

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/calcom/1/tickets/CALCOM-8998

[shaharyar-shamshi]

hello @PeerRich is this issue in the main branch because I checked the main branch from code perspective it is still label not identifier

[gitstart-calcom]

Hi @PeerRich We tried to reproduced the issue with a new added question (screenshot below)

And from the mail we have received, we noticed that the question label is used instead of identifier.

[hwdsjtu97]

@PeerRich Hi, I am interested in taking this one. Would you mind sharing how to get to the "add a question" page?

[PeerRich]

@hwdsjtu97 its in event-types > advanced settings > booking questions

[ujwalkumar1995]

Hey @PeerRich I tried replicating this issue but it is working fine for me. To replicate, I added a question in event types, then I created a booking. The email that I received was fine and was showing labels and not identifiers. Is it some specific scenario that is causing this?

[PeerRich]

can you try turning on "requires confirmation" and try again?

[ujwalkumar1995]

Hey @PeerRich Just to confirm are you seeing this issue on the live production app or is this something that you observed in your local machine from the main branch?

FYI: I tried this on the live production app with "requires confirmation" on but was not able to replicate it. On my local machine, I am not sure how we can replicate it without the SMTP server. I tried to put some logs to see what body is being passed to the email. Don't see anything wrong in there.