calcom
fix: footer in modals
Fixes #8414
Demo
https://www.loom.com/share/a82dc95a00e64f5092eeef9eda31559f
CAL-1543 Fix the footer in modals
Issue arose due to an issue where users "Can't see "Save" option on a longer form/booking question"
Designs:
Modal /Documentation: https://www.figma.com/file/9MOufQNLtdkpnDucmNX10R/❖-Cal-DS?node-id=29898%3A100590&t=4ZLIcu91Nx69ib75-1
Created via Threads. See full discussion: https://threads.com/34466132294
![linear[bot] avatar](https://avatars.githubusercontent.com/in/20150?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 30, 2023 3:13pm |
2 Ignored Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| api | ⬜️ Ignored (Inspect) | Visit Preview | May 30, 2023 3:13pm | |
| ui | ⬜️ Ignored (Inspect) | Visit Preview | May 30, 2023 3:13pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
![deploysentinel[bot] avatar](https://avatars.githubusercontent.com/in/210057?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think we want to add that new way of scrolling for all our modals. So we should make the changes to our Dialog component. (tagging @sean-brydon as part of the UI team)
think we want to add that new way of scrolling for all our modals. So we should make the changes to our Dialog component. (tagging @sean-brydon as part of the UI team)
Yeah we do - ideally a way of showing a clip mask when the content over flows.
I'm happy for that to be picked up in a seperate PR for it tho. I will create a new issue
Looks good. Two small things:
- Does it look like the content is being chopped off in the wrong spot? It should run all the way to the divider.
- Can we reduce the padding above/below the buttons?
Looks good. Two small things:
- Does it look like the content is being chopped off in the wrong spot? It should run all the way to the divider.
- Can we reduce the padding above/below the buttons?
Sure, we are on it
Hi @Jaibles, we have implemented the requested changes. Please take a look https://www.loom.com/share/61ccc1910f674707a8ed86aca2204513
Hi @Jaibles, we have implemented the requested changes. Please take a look
https://www.loom.com/share/61ccc1910f674707a8ed86aca2204513
Absolutely perfect 👌 Appreciate the loom with the inspect :)
Hi @CarinaWolli, we have made the required changes, please take a look https://www.loom.com/share/a82dc95a00e64f5092eeef9eda31559f