feat: make.com/integromat app

[aar2dee2]

What does this PR do?

Fixes #1550 /attempt #1550

Environment: Staging(main branch) / Production

Type of change

• New feature (non-breaking change which adds functionality)

How should this be tested?

• [ ] Test A
• [ ] Test B

Checklist

• I haven't added tests that prove my fix is effective or that my feature works
• I haven't checked if new and existing unit tests pass locally with my changes

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	🔄 Building (Inspect)			Sep 4, 2023 2:47pm
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 4, 2023 2:47pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 4, 2023 2:47pm
web-staging	🔄 Building (Inspect)			Sep 4, 2023 2:47pm

[vercel[bot]]

@aar2dee2 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[joeauyeung]

Hi @aar2dee2, great start on the app so far. I'm going to convert this PR to a draft as this isn't fully flushed out yet. Once you are done feel free to mark this PR as ready for review.

[PeerRich]

@aar2dee2 whats missing here to be ready for review?

[aar2dee2]

@aar2dee2 whats missing here to be ready for review?

Hi @PeerRich Still working on this, I'll push some commits in a few hours.

[aar2dee2]

So, I've got the webhooks & modules setup. Auth is working using a cal.com API key (similar to Zapier integration). Few changes needed, should be ready for review tomorrow. https://www.loom.com/share/00c29d32c7b64f9fb50e8cce29fcde32

[aar2dee2]

There a number of handlers that import the nodeScheduler from the Zapier app to perform an action when bookings are created/deleted etc. Do we want to follow the same approach for the Make integration?

• requestReschedule
• handleNewBooking
• handleConfirmation
• handleCancelBooking
• sendPayload

Will we need to handle Make as Zapier is handled in the files below?

• delete.handler
• deleteCredential.handler
• list.handler

@PeerRich tagging you, not sure who's the right person to answer this.

[aar2dee2]

Working integration with Google Sheets: https://www.loom.com/share/dd74c25570c2438a8d0e2fc354df73af

[PeerRich]

tagging you, not sure who's the right person to answer this.

@CarinaWolli built the zapier app and can help

[aar2dee2]

update: running into an issue in setting up the webhooks in the Make integration. Opened a discussion in the Make community: https://community.make.com/t/setting-up-webhook-instant-trigger-for-a-custom-app/11812

[github-actions[bot]]

Thank you for following the naming conventions! 🙏

[socket-security[bot]]

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

[aar2dee2]

Working integrations:

1. List Bookings
2. Booking Created
3. Booking Rescheduled
4. Booking Cancelled
5. Delete Subscription

[aar2dee2]

I'll clean up the README once the code is reviewed. Link to published app on Make.com - https://www.make.com/en/hq/app-invitation/6cb2772b61966508dd8f414ba3b44510

[PeerRich]

I'll clean up the README once the code is reviewed. Link to published app on Make.com - make.com/en/hq/app-invitation/6cb2772b61966508dd8f414ba3b44510

amazing! We're very excited about this cc @CarinaWolli

[CarinaWolli]

@aar2dee2 can you take a look at the lint errors?

[aar2dee2]

@aar2dee2 can you take a look at the lint errors?

done!

[PeerRich]

/bonus 20 hey @aar2dee2 would you mind fixing the merge conflicts?

[algora-pbc[bot]]

A bonus of $20 has been added to the bounty by PeerRich. @aar2dee2: You will receive a total of $420 once you implement the requested changes and your PR is merged.

[aar2dee2]

/bonus 20 hey @aar2dee2 would you mind fixing the merge conflicts?

Hey @PeerRich This is on my to-dos for the weekend!

[aar2dee2]

Hi, I'd love some help on a yarn error I'm running into.

On running git commit I get:

Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)

$ yarn run [--inspect] [--inspect-brk] [-T,--top-level] [-B,--binaries-only] <scriptName> ...
husky - pre-commit hook exited with code 1 (error)

yarn install fails with errors

my yarn version is 3.6.1 and node version v18.15.0

I checked that .yarnrc.yml is as per the Cal.com repo.

[shivamklr]

@aar2dee2 I recommend doing two things,

1. Refrain from pushing yarn.lock in the PR.
2. Use yarn clean and then yarn again to install deps again.

[aar2dee2]

@aar2dee2 I recommend doing two things,

1. Refrain from pushing yarn.lock in the PR.
2. Use yarn clean and then yarn again to install deps again.

Thanks for getting back @shivamklr

I deleted yarn.lock, ran yarn install again. Now git commit fails with the following error

[aar2dee2]

(Note: this is not the most updated version of the cal.com repo. I'd pulled changes earlier that I'm trying to merge)

[aar2dee2]

Hey Cal team, would love to complete and close this soon

[CarinaWolli]

@aar2dee2 How can I test that? And that would also mean we need to list the cal.com app on make.com, currently, it's just a private app in your make account, right?

[aar2dee2]

@aar2dee2 How can I test that? And that would also mean we need to list the cal.com app on make.com, currently, it's just a private app in your make account, right?

Hi @CarinaWolli

I published the app on Make, so you should be able to see it if you search for Cal.com. Here's a public link if required: https://www.make.com/en/hq/app-invitation/6cb2772b61966508dd8f414ba3b44510

I tested the app with a Google Sheets integration for all the events. Videos should be there earlier in the comments on this PR.

[aar2dee2]

Thank you for this PR, finally got the chance to fully test and review it. Overall it's looking pretty good, I left you some comments and questions. Some of them are blocking so requesting changes 🙏

Hey @CarinaWolli I've addressed all comments, lmk if any other updates are needed.

Thanks for the review!

[CLAassistant]

All committers have signed the CLA.