cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Add new events to webhook BOOKING_CONFIRMED, BOOKING_REJECTED

Open shivamklr opened this issue 2 years ago • 6 comments

What does this PR do?

  • Fixes #7299, except BOOKING_PAID, webhook which already is in a PR here #8721
  • Adds support for BOOKING_REQUESTED and BOOKING_REJECTED webhook in the code.
  • Tests BOOKING_REQUESTED and BOOKING_REJECTED webhooks with playwright

Loom Video Demo

Environment: Staging(main branch) / Production

Type of change

  • New feature (non-breaking change which adds functionality)
  • A bit of Refactoring
  • This change requires a documentation update

How should this be tested?

  • [x] Test webhook.e2e.ts with playwright

Checklist

  • ~~I haven't read the contributing guide~~
  • ~~My code doesn't follow the style guidelines of this project~~
  • ~~I haven't performed a self-review of my own code and corrected any misspellings~~
  • ~~I haven't commented my code, particularly in hard-to-understand areas~~
  • ~~I haven't checked if my PR needs changes to the documentation~~
  • ~~I haven't checked if my changes generate no new warnings~~
  • ~~I haven't added tests that prove my fix is effective or that my feature works~~
  • ~~I haven't checked if new and existing unit tests pass locally with my changes~~

shivamklr avatar May 14 '23 15:05 shivamklr

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 3:08pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 3:08pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 3:08pm

vercel[bot] avatar May 14 '23 15:05 vercel[bot]

@shivamklr is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 14 '23 15:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 14 '23 15:05 github-actions[bot]

Thanks for your review @joeauyeung. I am new to the codebase and really appreciate your assitance with the code review here.

shivamklr avatar May 20 '23 10:05 shivamklr

@CarinaWolli Thanks for the review 🙂

shivamklr avatar May 22 '23 16:05 shivamklr

@CarinaWolli @joeauyeung can you rereview?

PeerRich avatar May 22 '23 22:05 PeerRich