feat: Customise JITSI Url path
What does this PR do?
Allows the user to set a custom URL path with replacements insead of the UUID:
https://meet.mydomain.com/D64138E9-8912-47FD-8ED8-7A4673E7522F can become: https://meet.mydomain.com/30min-Meeting-with-Paul
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
- Bug fix (non-breaking change which fixes an issue)
- Chore (refactoring code, technical debt, workflow improvements)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How should this be tested?
- [ ] Add Pattern e.g. {Title}-{uuid}
- [ ] Create Jitis Meeting
Checklist
- I haven't added tests that prove my fix is effective or that my feature works
@hariombalhara ... didn't want the work from the JITSI HostURL to be unused (https://github.com/calcom/cal.com/pull/8636) ... so here is the code in a separate PR for discussion if that is useful (I think it is)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| api | 🔄 Building (Inspect) | May 31, 2023 6:29pm | ||
| ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 31, 2023 6:29pm |
@chief-nerd is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Five Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/apps/[slug]/[...pages] |
459.19 KB |
610.38 KB | 174.39% (🟡 +0.26%) |
/auth/setup |
174.91 KB |
326.1 KB | 93.17% (🟡 +0.17%) |
/event-types/[type] |
479.63 KB |
630.82 KB | 180.23% (🟡 +0.19%) |
/getting-started/[[...step]] |
426.28 KB |
577.47 KB | 164.99% (🟢 -0.22%) |
/settings/my-account/calendars |
252.55 KB |
403.74 KB | 115.35% (🟢 -0.23%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-
@PeerRich Blocking it till we address if we want to do it and if it's the right approach.
Ok. Is there a timeframe?
@hariombalhara would you mind re-reviewing?
seems like some lint issues @chief-nerd
We need to use the same variables
Event Type Title,Organizer,Scheduler,Location
Can do it tomorrow. (including the linting).
@hariombalhara fixed the variable names and corrected the linting. Ready to merge.