#8783 Adjust height of sidebar to fit on screen when top banner is visible
Adjusts the height of the sidebar to fit on screen and not be scrollable when top banner is visible.
Fixes #8783
https://www.loom.com/share/dcaee4eae95f42ae941e2ef2bfefd4e3
Environment: Staging(main branch) / Production
Type of change
- Bug fix (non-breaking change which fixes an issue)
How should this be tested?
Go to the event-types page and observe the sidebar when a banner is visible on the top.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| api | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 30, 2023 2:49pm |
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 30, 2023 2:49pm |
| ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 30, 2023 2:49pm |
@paridhi7 is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
@Udit-takkar fixed it!
@paridhi7 you might wanna have a look here https://github.com/calcom/cal.com/pull/6098/files#r1052035715 (maybe adding a div with position fixed in sidebar component outside of userdropdown ) and https://github.com/calcom/cal.com/pull/6228/files#diff-682568b9bcea96dd5dfd183b5b3303e27c13ac922731e9d2a26d65b8e59d342d.
Make sure to test it properly. also with Tips Component active like you can see in my image
Hi @Udit-takkar, can you please take a look now? I have made the top banner fixed as @Jaibles mentioned on the Loom that I attached with the PR.
The events page looks like this now: https://www.loom.com/share/9eb5d61801ec44afba1040bc8829c5f7