cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-1636] Notification for disconnected calendar not showing on the event types screen

Open ciaranha opened this issue 2 years ago • 2 comments

When a calendar becomes disconnected, we need to treat this as a high priority error for our users and show a top banner across all pages on the app.

This should appear on desktop and mobile.

Desktop

CleanShot 2023-05-09 at 10.00.49@2x.png

Mobile

CleanShot 2023-05-09 at 10.00.59@2x.png

It should use our Top banner component from our DS

Context where issue arose: https://calcominc.slack.com/archives/C04CWEU35NV/p1683622346411839

From SyncLinear.com | CAL-1636

ciaranha avatar May 09 '23 09:05 ciaranha

@Jaibles should the banner dismissible in desktop also ?

G3root avatar May 09 '23 09:05 G3root

@Jaibles should the banner dismissible in desktop also ?

Good catch. I actually meant to remove it on mobile before posting. I don't think it should be dismissible. I think if you previously had a calendar connected, you should have to reconnect. If you want the banner to go away, you would have to reconnect or delete it from your calendar connections entirely. @shirazdole wdyt?

ciaranha avatar May 09 '23 09:05 ciaranha

@G3root No need to wait for @shirazdole response here btw, we can tackle it as non dismissable and edit later if we need.

ciaranha avatar May 11 '23 08:05 ciaranha