cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fixed ui bug

Open swarajbachu opened this issue 2 years ago • 7 comments

What does this PR do?

Fixes: https://github.com/calcom/cal.com/issues/8707

I fixed the alignment of search bar in /app

Screenshot 2023-05-07 at 8 06 55 PM Screenshot 2023-05-07 at 8 07 09 PM

Fixes # (issue)

  • I added m-1 which gives it a little margin for all the sides and fix the alignment issue for all devices Screenshot 2023-05-07 at 8 08 31 PM Screenshot 2023-05-07 at 8 09 20 PM

@PeerRich @Udit-takkar

swarajbachu avatar May 07 '23 14:05 swarajbachu

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 7:23pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 7:23pm

vercel[bot] avatar May 07 '23 14:05 vercel[bot]

@swarajbachu is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 07 '23 14:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 456.11 KB 606.89 KB 173.40% (🟢 -0.17%)
/auth/setup 174.09 KB 324.88 KB 92.82% (🟢 -0.16%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 07 '23 14:05 github-actions[bot]

@PeerRich @Udit-takkar

swarajbachu avatar May 08 '23 06:05 swarajbachu

@swarajbachu I am not able to reproduce the bug on app.cal.com. Has it been fixed already ?

Screenshot 2023-05-08 at 2 17 08 PM

when you click on it, the focus mode is out of alientment, for all the devices!

swarajbachu avatar May 08 '23 09:05 swarajbachu

@Udit-takkar pls check this, small change

swarajbachu avatar May 08 '23 13:05 swarajbachu

Screenshot 2023-05-08 at 8 07 23 PM

LGTM A bit hacky solution though

got it, why isnt it merged yet?

swarajbachu avatar May 08 '23 15:05 swarajbachu