cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Updated The Slugify to accept username as emoji

Open pranjalg13 opened this issue 2 years ago • 3 comments

What does this PR do?

Added changes to accept emoji as username

  • Previously it updates the emoji as (--) instead of the actual emoji
  • Added a regex in which the u flag enables Unicode matching, and the g flag enables global matching (i.e., all matches are replaced, not just the first one).

Fixes #7718

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • [ ] Before code changes the emoji username where updated with -- value
  • [ ] After this change it is updated according to the emoji provided and /avatar/emoji path is also working fine

Changes Screenshot

Screenshot 2023-05-07 at 7 55 01 PM Screenshot 2023-05-07 at 7 58 09 PM

pranjalg13 avatar May 07 '23 14:05 pranjalg13

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2023 3:16pm

vercel[bot] avatar May 07 '23 14:05 vercel[bot]

@pranjalg13 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 07 '23 14:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 07 '23 14:05 github-actions[bot]

@PeerRich @zomars please review this once Thanks

pranjalg13 avatar May 09 '23 03:05 pranjalg13

Thanks for your contribution. I'm gonna close this in favour of https://github.com/calcom/cal.com/pull/8740 as also improves functionality of our slugify function

sean-brydon avatar May 09 '23 07:05 sean-brydon

Cool. no issues @sean-brydon

pranjalg13 avatar May 09 '23 15:05 pranjalg13