cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard
verified publisher icon calcom

[CAL-1610] Every CalendarService must send externalCalendarId

Open hariombalhara opened this issue 2 years ago • 1 comments 

          This was causing reschedule to not update the Bigin Event. This might be a problem with other CRM apps as well.

Originally posted by @hariombalhara in https://github.com/calcom/cal.com/pull/8158#discussion_r1181552060

If a CalendarService doesn't set externalCalendarId, it's updateEvent never get's called. This check exists here and I think we should do away with this requirement in updateAllCalendarEvents https://github.com/calcom/cal.com/blob/810a4e6b7f829183dee8a798e08346f082cfb8f9/packages/core/EventManager.ts#L459

cc @zomars

CAL-1610

hariombalhara avatar May 01 '23 12:05 hariombalhara

@hariombalhara, the external id has references in the updateEvent of CalendarManager.ts, should I go ahead and remove those too?

zeeshanbhati avatar May 02 '23 22:05 zeeshanbhati

@hariombalhara , When I checked the update event function in the Calendar service it doesn't need externalId as parameter, I am unable to understand why it is used in the calendar.updateEvent function in Calendar Manager.

image

CalendarManager, if I am not getting it wrong then calendar is an instance of CalendarService

Function Definition of update event in CalendarService.tsx

image

zeeshanbhati avatar May 09 '23 22:05 zeeshanbhati