[CAL-1545] replace heroicons with lucide.dev
Fixes #8423
Demo
https://www.loom.com/share/8aa29b6ff81e4419b3315bb6c79430d5
Icons after the changes

Icons before the changes

Note: We could not find the pages where the icons were being used that's why we are showing just the icons
CAL-1545 replace heroicons with lucide.dev
we are now using lucide.dev in calcom/icons and we should get rid of heroicons altogether:
gitstart-calcom one thing to keep in mind is that the default sizes of lucide.dev icons may be different than the default sizes of heroicons, which means you may need to add className="w-4 h-4" or similar to the lucide.dev icons when removing hero icons.
for this PR, can you take screenshots of before and after for every icon?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 17, 2023 7:26am |
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ui | ⬜️ Ignored (Inspect) | Visit Preview | May 17, 2023 7:26am |
New dependency changes detected. Learn more about Socket for GitHub ↗︎
👍 No new dependency issues detected in pull request
Bot Commands
To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all
Pull request alert summary
| Issue | Status |
|---|---|
| Install scripts | ✅ 0 issues |
| Native code | ✅ 0 issues |
| Bin script shell injection | ✅ 0 issues |
| Unresolved require | ✅ 0 issues |
| Invalid package.json | ✅ 0 issues |
| HTTP dependency | ✅ 0 issues |
| Git dependency | ✅ 0 issues |
| Potential typo squat | ✅ 0 issues |
| Known Malware | ✅ 0 issues |
| Telemetry | ✅ 0 issues |
| Protestware/Troll package | ✅ 0 issues |
📊 Modified Dependency Overview:
| ⬆️ Updated Package | Version Diff | Added Capability Access | +/- Transitive Count |
Publisher |
|---|---|---|---|---|
| [email protected] | 0.130.1...0.171.0 | None | +0/-0 |
ericfennis |
🚮 Removed packages: @heroicons/[email protected]
@gitstart-calcom
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Fifty-three Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/[user]/[type] |
183.4 KB |
334.3 KB | 95.52% (🟢 -0.16%) |
/[user]/[type]/embed |
183.43 KB |
334.33 KB | 95.52% (🟢 -0.15%) |
/apps |
275.16 KB |
426.07 KB | 121.73% (🟢 -0.31%) |
/apps/[slug] |
293.1 KB |
444 KB | 126.86% (🟢 -0.31%) |
/apps/[slug]/[...pages] |
455.94 KB |
606.84 KB | 173.38% (🟢 -0.31%) |
/apps/categories |
237.61 KB |
388.51 KB | 111.00% (🟢 -0.31%) |
/apps/categories/[category] |
258.36 KB |
409.26 KB | 116.93% (🟢 -0.31%) |
/apps/installed/[category] |
275.74 KB |
426.64 KB | 121.90% (🟢 -0.39%) |
/auth/setup |
174.03 KB |
324.94 KB | 92.84% (🟢 -0.26%) |
/availability |
242.93 KB |
393.83 KB | 112.52% (🟢 -0.31%) |
/availability/[schedule] |
330.16 KB |
481.07 KB | 137.45% (🟢 -0.35%) |
/availability/troubleshoot |
238.29 KB |
389.2 KB | 111.20% (🟢 -0.31%) |
/bookings/[status] |
338.17 KB |
489.08 KB | 139.74% (🟢 -0.37%) |
/d/[link]/[slug] |
183.04 KB |
333.95 KB | 95.41% (🟢 -0.15%) |
/d/[link]/[slug]/embed |
183.07 KB |
333.98 KB | 95.42% (🟢 -0.15%) |
/event-types |
424.97 KB |
575.87 KB | 164.53% (🟢 -0.30%) |
/event-types/[type] |
477.26 KB |
628.17 KB | 179.48% (🟢 -0.29%) |
/insights |
446.45 KB |
597.35 KB | 170.67% (🟢 -0.31%) |
/more |
237.23 KB |
388.14 KB | 110.90% (🟢 -0.31%) |
/settings/admin |
242.8 KB |
393.7 KB | 112.49% (🟢 -0.32%) |
/settings/admin/apps |
254.04 KB |
404.95 KB | 115.70% (🟢 -0.42%) |
/settings/admin/apps/[category] |
254.03 KB |
404.93 KB | 115.70% (🟢 -0.42%) |
/settings/admin/flags |
245.44 KB |
396.35 KB | 113.24% (🟢 -0.31%) |
/settings/admin/impersonation |
243.08 KB |
393.98 KB | 112.57% (🟢 -0.32%) |
/settings/admin/users |
244.22 KB |
395.12 KB | 112.89% (🟢 -0.31%) |
/settings/admin/users/[id]/edit |
331.45 KB |
482.36 KB | 137.82% (🟢 -0.32%) |
/settings/admin/users/add |
331.13 KB |
482.03 KB | 137.72% (🟢 -0.31%) |
/settings/billing |
242.94 KB |
393.84 KB | 112.53% (🟢 -0.32%) |
/settings/developer/api-keys |
271.51 KB |
422.41 KB | 120.69% (🟢 -0.32%) |
/settings/developer/webhooks |
245.31 KB |
396.22 KB | 113.20% (🟢 -0.31%) |
/settings/developer/webhooks/[id] |
248.8 KB |
399.7 KB | 114.20% (🟢 -0.29%) |
/settings/developer/webhooks/new |
248.66 KB |
399.56 KB | 114.16% (🟢 -0.29%) |
/settings/my-account/appearance |
257.27 KB |
408.17 KB | 116.62% (🟢 -0.31%) |
/settings/my-account/calendars |
250.69 KB |
401.59 KB | 114.74% (🟢 -0.27%) |
/settings/my-account/conferencing |
248.54 KB |
399.44 KB | 114.13% (🟢 -0.30%) |
/settings/my-account/general |
324.86 KB |
475.76 KB | 135.93% (🟢 -0.31%) |
/settings/my-account/profile |
370.85 KB |
521.75 KB | 149.07% (🟢 -0.19%) |
/settings/security/impersonation |
244.71 KB |
395.61 KB | 113.03% (🟢 -0.31%) |
/settings/security/password |
255.43 KB |
406.34 KB | 116.10% (🟢 -0.32%) |
/settings/security/sso |
252.3 KB |
403.2 KB | 115.20% (🟢 -0.32%) |
/settings/security/two-factor-auth |
247.13 KB |
398.04 KB | 113.72% (🟢 -0.31%) |
/settings/teams |
242.56 KB |
393.47 KB | 112.42% (🟢 -0.31%) |
/settings/teams/[id]/appearance |
257.08 KB |
407.99 KB | 116.57% (🟢 -0.32%) |
/settings/teams/[id]/billing |
242.8 KB |
393.71 KB | 112.49% (🟢 -0.32%) |
/settings/teams/[id]/members |
356.46 KB |
507.37 KB | 144.96% (🟢 -0.31%) |
/settings/teams/[id]/profile |
365.81 KB |
516.71 KB | 147.63% (🟢 -0.31%) |
/settings/teams/[id]/sso |
252.4 KB |
403.3 KB | 115.23% (🟢 -0.32%) |
/settings/teams/new |
182.23 KB |
333.14 KB | 95.18% (🟢 -0.20%) |
/team/[slug]/[type] |
183.05 KB |
333.95 KB | 95.41% (🟢 -0.15%) |
/team/[slug]/[type]/embed |
183.08 KB |
333.98 KB | 95.42% (🟢 -0.15%) |
/teams |
237.33 KB |
388.23 KB | 110.92% (🟢 -0.31%) |
/workflows |
250.18 KB |
401.08 KB | 114.60% (🟢 -0.32%) |
/workflows/[workflow] |
366.52 KB |
517.42 KB | 147.83% (🟢 -0.31%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-
Current Playwright Test Results Summary
✅ 112 Passing - ⚠️ 3 Flaky
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 05/17/2023 07:41:50am UTC)
Run Details
Running Workflow PR Update on Github Actions
Commit: 54d85873962b789dbf497308bd2b9b3fe36e902b
Started: 05/17/2023 07:31:45am UTC
⚠️ Flakes
📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
1.74% (5)5 / 288 runsfailed over last 7 days |
24.65% (71)71 / 288 runsflaked over last 7 days |
📄 apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1 • Initial Attempt |
5.78% (17)17 / 294 runsfailed over last 7 days |
29.93% (88)88 / 294 runsflaked over last 7 days |
📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt |
0% (0)0 / 298 runsfailed over last 7 days |
82.21% (245)245 / 298 runsflaked over last 7 days |
Hi @PeerRich, the failing tests have been fixed now
still failing @gitstart-calcom
still failing @gitstart-calcom
It's failing because the new changes from the main branch have heroicons. We have fixed this on our end and will push the changes along with the before and after screenshots.