cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-1546] Hide "Record" button when organiser is on FREE account

Open PeerRich opened this issue 2 years ago • 7 comments

right now we always show the record button, but only TEAM users can download.

this causes issues for people who are unaware of it and record a video just to realise they need a TEAM plan.

From SyncLinear.com | CAL-1546

PeerRich avatar Apr 20 '23 23:04 PeerRich

According to daily:

if you are setting the enable_recording property at the room level then it will be shown to all users that join the session. If instead enable_recording is set at via a meeting token, then recording controls will only be available for users that join using that meeting token

PeerRich avatar Apr 20 '23 23:04 PeerRich

Hi, just to confirm. We only want to show the record button if the host in on a team plan right?

Jonathan1599 avatar Apr 26 '23 06:04 Jonathan1599

yes!

PeerRich avatar Apr 26 '23 08:04 PeerRich

Cool, I'll take this up

Jonathan1599 avatar Apr 26 '23 08:04 Jonathan1599

it seams like this piece of code also has to check for isTeamsPlan

CleanShot 2023-04-26 at 10 23 23@2x

PeerRich avatar Apr 26 '23 08:04 PeerRich

https://github.com/calcom/cal.com/tree/main/packages/app-store/dailyvideo/lib/VideoApiAdapter.ts

PeerRich avatar Apr 26 '23 08:04 PeerRich

fyi: "scalePlan" refers to the daily.co .env variable: "SCALE_PLAN" which not every self-hoster has activated

PeerRich avatar Apr 26 '23 08:04 PeerRich