calcom
[CAL-1182] Merge and reuse components settings/conferencing and installed/[category]
Both of these pages have heavy overlap and a lot of repeated code across them - we can consolidate them into more reusable components to save having to make changes in two places (As conferencing category on installed does the exact same as settings :) )
@Jaibles Is having duplicate pages with the same results intended?
From SyncLinear.com | CAL-1182
Can I be assigned on this issue? I'll look into it but might take a while doing it.
@sean-brydon Saw the the settings/conferencing page from /settings/my-account/conferencing but not sure what page are you referring to for installed/[category] .
@Jaibles Is having duplicate pages with the same results intended?
Yes @sean-brydon this is intended. Calendars & conferencing are so important for people to have setup that it is deemed essential setting. We had many queries in v1 of Cal where people didn't find it in Installed Apps. However, it wouldn't make sense to remove it from Installed Apps just because we have it in settings, since it is technically an installed app.
In both instances we should use the list item components and of course re-use code where possible like you suggested List item component
@PeerRich - Can you as assign it to me. I can work on this and prefer to mess up someone else's time by 2 PRs.
PS: I have experience contributing to OSS, I come from GitLab 😄
Ok, so I had an initial look at both the files, since I am new to TypeScript and in process of learning it, I found below blocks, very similar in both the files.
In conferencing.tsx - https://github.com/calcom/cal.com/blob/main/apps/web/pages/settings/my-account/conferencing.tsx#L135-L154
And in installed/[category] - https://github.com/calcom/cal.com/blob/main/apps/web/pages/apps/installed/%5Bcategory%5D.tsx#L167-L187
Basically one of the drop down menu items is staggeringly similar, does this issue intend to merge the menu item and hook it at both the places?
If so, I would need some help on how do I do it. 😅
