calcom
[CAL-1030] fix flickering border issue in menu layout for mobile
What does this PR do?
- Fixing the flickering border issue in menu layout for mobile
Fixes #6992
https://user-images.githubusercontent.com/73758525/218095690-1f1816a0-c52c-4bc5-8cc0-30fdef2db578.mov
Environment: Staging(main branch) / Production
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
How should this be tested?
- Run the web app locally and go to
/event-types - Test the menu layout
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated |
|---|---|---|---|---|
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 13, 2023 at 3:35PM (UTC) |
| ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 13, 2023 at 3:35PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@amirfakhrullah is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
@amirfakhrullah try to use DropdownItem inside DropdownMenuItem if possible just like it is used in other parts of codebase
@Udit-takkar I just changed it. I can confirm that all pages/sections that use the DropdownMenuItem component working fine:
https://user-images.githubusercontent.com/73758525/218243129-25e06737-5d68-44eb-8ae0-47260ae306f0.mov
https://user-images.githubusercontent.com/73758525/218243116-301efdaa-b030-46ec-a47b-ac05991f095d.mov
@amirfakhrullah Works great 👏. In the first video just make sure there are no double borders in the delete item
Done @Udit-takkar . Here's the vid:
https://user-images.githubusercontent.com/73758525/218245939-4316ddee-bd63-49c1-9c58-c83a67e3481b.mov