cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: flash of grey while hard reloading app detail page

Open G3root opened this issue 3 years ago • 5 comments

What does this PR do?

  • [x] fixes back button style in app detail view
  • [x] fixes flash of grey while hard reloading app detail page - ex: https://app.cal.com/apps/hubspot
  • [x] fixes untranslated i18n placeholder flash

button after: Screenshot 2023-01-18 22:51:37

Environment: Staging(main branch) / Production

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Chore (refactoring code, technical debt, workflow improvements)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How should this be tested?

  • [ ] Test A
  • [ ] Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

G3root avatar Jan 18 '23 17:01 G3root

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 6:04AM (UTC)
cal-com-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 6:04AM (UTC)

vercel[bot] avatar Jan 18 '23 17:01 vercel[bot]

@emrysal can you review this? you have the most experience with the public app store page

PeerRich avatar Jan 21 '23 17:01 PeerRich

One thing that I think we should fix too is the display of the sidebar during load on https://cal-git-fix-appstore-flash-cal.vercel.app/apps/basic - @PeerRich This PR or follow up? (I'd say this PR as it fixes similar issues)

emrysal avatar Jan 21 '23 17:01 emrysal

@emrysal i think this has been fixed from some other PR. pushed the latest main to the PR and it seem good now https://cal-5whv607bg-cal.vercel.app/apps/basic

G3root avatar Jan 23 '23 06:01 G3root

so I guess we can close this?

PeerRich avatar Jan 23 '23 09:01 PeerRich

Closing for now

zomars avatar Jan 24 '23 19:01 zomars