calcom
A Playwright test for "Copy Typeform Redirect URL link" action
What does this PR do?
Fixes #4570
Environment: Staging(main branch) / Production
Type of change
- [x] Chore (refactoring code, technical debt, workflow improvements)
@gitstart is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@PeerRich This is the only test we need to ensure Typeform app is working fine. So, I think we should have it.
@gitstart But the test should be inside Typeform app
@PeerRich This is the only test we need to ensure Typeform app is working fine. So, I think we should have it.
@gitstart But the test should be inside Typeform app
Looks like a misunderstanding on our part, will make the required changes and get back to you @hariombalhara
@hariombalhara PR has been updated, please take a look
We updated the test with the Typeform install and hope we are now testing the correct button. Is it necessary to test within https://www.typeform.com/? If necessary, we don't know how we could do that, as it requires logging into the site, and in addition, the related functionality is paid for.
@gitstart Oh sorry for confusion. I actually meant it should be placed insidetypeform app in our app-store. I don't mean to actually test typeform webapp.
Right now the test is added in routing-forms app. But a routing form app isn't bundled with Typeform App. Typeform app is installed separately and thus the test needs to be part of that app in our app-store
@gitstart Oh sorry for confusion. I actually meant it should be placed insidetypeform app in our app-store. I don't mean to actually test typeform webapp.
Right now the test is added in routing-forms app. But a routing form app isn't bundled with Typeform App. Typeform app is installed separately and thus the test needs to be part of that app in our app-store
Hey @hariombalhara, is the test still incorrect? Thought we can use Typeform only through the Routing Form
Yes, Typeform App can't be used without Routing Forms. But the feature that we are testing belongs to Typeform App only. So, it would be the responsibility of Typeform App playwright code to install Routing Form and Typeform Apps during testing and test the appropriate behaviour.
But this is a small testcase which has already been written. So, I think we would be able to merge it with a TODO that the tests need to be moved to Typeform App