cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Add ability to hide back button on event type booking page

Open gitstart opened this issue 3 years ago • 4 comments

What does this PR do?

Removes back button on event type booking page when all event types are hidden

Fixes #5056

Loom Video: https://www.loom.com/share/d4c20b1655d84b2a92a03bea770a3abc

Environment: Staging(main branch) / Production

Type of change

  • [x] New feature (non-breaking change which adds functionality)

gitstart avatar Nov 07 '22 15:11 gitstart

@gitstart is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 07 '22 15:11 vercel[bot]

  • Added a new query to fetch event types
  • Filtered out hidden events from the list of public ones
  • Changed the condition for displaying GoBackToPreviousPage component so that it is only displayed when there are any public event types available (i.e., not all have been filtered out)

what-the-diff[bot] avatar Nov 07 '22 15:11 what-the-diff[bot]

Hi @PeerRich! Please review the PR

gitstart avatar Nov 11 '22 10:11 gitstart

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 0:45AM (UTC)

vercel[bot] avatar Nov 25 '22 17:11 vercel[bot]

Hey @zomars, please take a look at the PR 🙏

gitstart avatar Dec 05 '22 13:12 gitstart

I think we're actually removing the back button for now, right @Jaibles ?

PeerRich avatar Dec 05 '22 13:12 PeerRich

I think we're actually removing the back button for now, right @Jaibles ?

Do you want this PR to handle removing the back button or are we closing this one?

gitstart avatar Dec 05 '22 14:12 gitstart

I think we're actually removing the back button for now, right @Jaibles ?

Do you want this PR to handle removing the back button or are we closing this one?

yeah i think we can do it here

PeerRich avatar Dec 05 '22 21:12 PeerRich

sorry @sean-brydon, you tried! 🥲

PeerRich avatar Dec 06 '22 13:12 PeerRich

@sean-brydon

The More You Know Nice Try GIF by reactionseditor

zomars avatar Dec 06 '22 19:12 zomars