cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

use new v2 Dropdown in booking page

Open gitstart opened this issue 3 years ago • 6 comments

What does this PR do?

Fixes #4508

Demo

https://www.loom.com/share/3883a9c491d74e4b8ea6d4a049409a26

Environment: Staging(main branch) / Production

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Chore (refactoring code, technical debt, workflow improvements)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

gitstart avatar Sep 19 '22 09:09 gitstart

@gitstart is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 19 '22 09:09 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 4:22PM (UTC)

vercel[bot] avatar Sep 19 '22 16:09 vercel[bot]

this doesnt solve the issue. we want to use the <Dialog> component from v2

PeerRich avatar Sep 19 '22 16:09 PeerRich

this doesnt solve the issue. we want to use the <Dialog> component from v2

Thank you for the review @PeerRich, will get back to you with the required changes asap

gitstart avatar Sep 19 '22 17:09 gitstart

this doesnt solve the issue. we want to use the <Dialog> component from v2

Hey @PeerRich can you please give more clarification on this? Do we want to replace Collapsible with Dialog?

gitstart avatar Sep 20 '22 10:09 gitstart

this doesnt solve the issue. we want to use the <Dialog> component from v2

Hey @PeerRich can you please give more clarification on this? Do we want to replace Collapsible with Dialog?

correct

PeerRich avatar Sep 20 '22 14:09 PeerRich