Remove branding doesn't work for lifetime / vanity name purchasers
Hello,
I bought the tim vanity name, and while I do have the UI option ti disable branding:
It still shows up:
This to me looks like somewhat related to #4580 — since I don't see any branding on Tim's page. @zomars Perhaps you know if anything changed in the cloudflare caching with the new release? To me it seems that because of SWR you sometimes see a stale version first (containing in this case for example still the branding and in case of the other ticket the old theme), and after another refresh you get the updated version, where eg the branding is gone. What's your thought on that?
@timfee It doesn't replicate for us on your link. Might be related to what @JeroenReumkens said but I tried in my account and it works there.
Hey I could take a look at this @hariombalhara I think you're right about what @JeroenReumkens said. I think the problem is dark settings come from getServerSideProps, which are not invalidated as trpc queries are. Also we can't really invalidate swr cache I think.
would it be better to try to sync darkTheme settings somehow differently? With something that does get updated when settings are, like a mutation? which can be invalidated/auot-re-fetched