cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

/event-types make switch async

Open gitstart opened this issue 3 years ago • 2 comments

What does this PR do?

Previously when the hide switch is clicked we wait for a response from the server before the switch is toggled. These changes enable optimistic updates of the hidden property on a switched eventType, and roll-backs the changes if the switching fails. So now the switch and hidden label no longer wait for the server response.

Fixes #4130

Environment: Staging(main branch) / Production

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Chore (refactoring code, technical debt, workflow improvements)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Demo

https://www.loom.com/share/7907fbdf0bf646ccbe8b27b8d10375a4

gitstart avatar Sep 09 '22 16:09 gitstart

@gitstart is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 09 '22 16:09 vercel[bot]

Hi @sean-brydon! Thank for the review, will get back to you with the requested changes asap

gitstart avatar Sep 15 '22 16:09 gitstart

closing this PR for now, will push a different PR with required changes

gitstart avatar Sep 29 '22 04:09 gitstart