fix: show hidden badge on mobile view for event types
What does this PR do?
- Fixes #25700
- Fixes CAL-6881
Visual Demo (For contributors especially)
Image Demo (if applicable):
before in mobile view:
after in mobile view:
Mandatory Tasks (DO NOT REMOVE)
- [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
- [ ] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
- [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.
Summary by cubic
Shows the "Hidden" badge on mobile in the Event Types list for non-managed types and fixes the hidden toggle in the infinite list. Addresses CAL-6881.
Written for commit bf6fa769600f45043f5940be8e043fdb7a05262f. Summary will update automatically on new commits.
@KartikLabhshetwar is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
I tested this and it’s not working as expected. The badge should appear without needing to reload the page. Could you revisit the logic and make sure it updates automatically?
Screen.Recording.2025-12-08.at.4.29.58.PM.mov
https://github.com/user-attachments/assets/d33c3496-2469-460d-ae7a-83342d8f5e55
hi @dhairyashiil, fixed the hidden badge not updating immediately the mutation was mutating the pages prop directly, which doesn't trigger react re-renders, replaced it with setInfiniteData to update the react query cache immutably, matching the pattern used by deleteMutation in the same file. The badge now updates immediately when toggling the hidden status without a page reload.
can you check on the failing unit tests.
Hi, @Pallava-Joshi i verified and no tests are failing for the changes which i have done. kindly review the pr once again.