cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix(settings): improve spacing between navigation child items

Open KartikLabhshetwar opened this issue 2 months ago • 4 comments

What does this PR do?

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Image Demo (if applicable):

before: Screenshot 2025-12-05 at 12 44 51 PM Screenshot 2025-12-05 at 12 56 33 PM Screenshot 2025-12-06 at 2 21 12 PM

after: Screenshot 2025-12-05 at 12 48 56 PM Screenshot 2025-12-05 at 1 03 18 PM Screenshot 2025-12-06 at 2 18 29 PM

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [ ] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.

KartikLabhshetwar avatar Dec 05 '25 07:12 KartikLabhshetwar

@KartikLabhshetwar is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 05 '25 07:12 vercel[bot]

please create an issue and link the PR to it. Also, it would be really helpful if you could revert the Prettier changes in this file to make the review easier. Thankss

hi @dhairyashiil i have removed the prettier formatting, can you please review this once again?

KartikLabhshetwar avatar Dec 05 '25 09:12 KartikLabhshetwar

Are we also changing the border radius for outer div?

Screenshot 2025-12-05 at 3 27 30 PM maybe we should change only inner one

We're only changing the inner items (DropdownMenuItem), not the outer container (DropdownMenuContent).

KartikLabhshetwar avatar Dec 05 '25 11:12 KartikLabhshetwar

hi @dhairyashiil i have fixed the spacing issue between booking navigation, also address the issues which you mentioned.

before: Screenshot 2025-12-06 at 2 21 12 PM

after: Screenshot 2025-12-06 at 2 18 29 PM

KartikLabhshetwar avatar Dec 06 '25 08:12 KartikLabhshetwar

Applied the same fix here:

Screenshot 2025-12-12 at 12 02 12 AM

dhairyashiil avatar Dec 11 '25 18:12 dhairyashiil