cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: use meeting summary and ai companion settings

Open chaitanyya opened this issue 7 months ago • 4 comments

What does this PR do?

We use the correct user configuration for ai_companion and meeting_summary. As complaint by

  • Fixes #21770 (GitHub issue number)
  • Fixes CAL-5916

Video Demo

https://www.loom.com/share/3538202146b840469a2721f49563716b

Mandatory Tasks

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • If you have a zoom pro account, enable meeting summary and ai companion across your account
  • Create a new meeting wit Cal link
  • The correct configuration is added to the meeting when created
Screenshot 2025-06-11 at 5 04 56 PM

Summary by cubic

Fixed meeting creation to use the correct user settings for meeting summary and companion features in Zoom.

  • Bug Fixes
    • Reads and applies user preferences for meeting summary and companion auto-start when scheduling meetings.

chaitanyya avatar Jun 11 '25 23:06 chaitanyya

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 11 '25 23:06 CLAassistant

@chaitanyya is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 11 '25 23:06 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (06/11/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (06/11/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (07/11/25)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Jun 11 '25 23:06 graphite-app[bot]

@Devanshusharma2005 also this one, i did try it out with a paid account and it worked fine, super simple happy to add more context if that makes things easier for you

chaitanyya avatar Jun 15 '25 03:06 chaitanyya

@chaitanyya could you pls resolve the merge conflicts?

kart1ka avatar Jul 10 '25 18:07 kart1ka

@kart1ka it's done, would be great if we can clean it up soon

chaitanyya avatar Jul 11 '25 00:07 chaitanyya

E2E results are ready!

github-actions[bot] avatar Jul 11 '25 18:07 github-actions[bot]

This one has been sitting for a while, would be great if we can merge this

chaitanyya avatar Jul 11 '25 18:07 chaitanyya

Walkthrough

The changes update the Zoom user settings schema to add two new optional nested objects, meeting_summary_with_ai_companion and ai_companion_questions, each with an optional auto_enable boolean under the in_meeting section. The waiting_room property is made optional and nullable. The API filter string is modified to include the in_meeting field to ensure retrieval of these new settings. In the meeting creation logic, two new boolean flags are introduced and set based on the corresponding user settings, defaulting to false if not present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective Addressed Explanation
Ensure "Automatically start meeting summary" is enabled if "Turn on meeting summary automatically when meetings start" is true (#21770, CAL-5916)
Ensure "Automatically start AI Companion" is enabled if the corresponding setting is true (#21770, CAL-5916)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.

[!NOTE]

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 08 '25 14:08 coderabbitai[bot]