cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: Persist filters across tabs to improve user experience

Open weknowyourgame opened this issue 8 months ago • 7 comments

What does this PR do?

  • Fixes #21696 (GitHub issue number)
  • Fixes CAL-5892

Video Demo (if applicable):

https://www.loom.com/share/ca5724760ad340fc9fc812c80b2cdd38?sid=b045c088-cc49-4fd3-a31a-62266789208f

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

Summary by cubic

Filters now stay applied when switching between booking tabs, making it easier to keep your view consistent. This improves the user experience when managing bookings.

weknowyourgame avatar Jun 04 '25 12:06 weknowyourgame

@weknowyourgame is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 04 '25 12:06 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (06/04/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (06/04/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (06/16/25)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Jun 04 '25 12:06 graphite-app[bot]

@weknowyourgame could you pls add a loom?

anikdhabal avatar Jun 04 '25 12:06 anikdhabal

sure, @anikdhabal https://www.loom.com/share/ca5724760ad340fc9fc812c80b2cdd38?sid=b045c088-cc49-4fd3-a31a-62266789208f

theres some lag in the first 40secs pls ignore video will start from around ~1 min

weknowyourgame avatar Jun 04 '25 13:06 weknowyourgame

hey @weknowyourgame can you add a loom for before and after doing the changes.

Devanshusharma2005 avatar Jun 12 '25 03:06 Devanshusharma2005

Hey @Devanshusharma2005 I had already included the video link in the PR body, but just to make it easier, I’m uploading it here as well

Before: https://github.com/user-attachments/assets/ded97ec2-1742-4608-832d-8c240fc9abc4

After: https://github.com/user-attachments/assets/38925f13-dae6-4c13-ab17-c78efb93b9c6

weknowyourgame avatar Jun 14 '25 12:06 weknowyourgame

E2E results are ready!

github-actions[bot] avatar Jun 16 '25 11:06 github-actions[bot]