cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard
verified publisher icon calcom

fix: added classNames prop to the DatePicker component

Open weknowyourgame opened this issue 8 months ago • 4 comments

What does this PR do?

The Booker component renders the DatePicker in main area and the sidebar. ClassNames prop was missing in DatePicker component that's rendered in the sidebar.

  • Fixes #21516 (GitHub issue number)
  • Fixes CAL-5826

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

Summary by cubic

Added the classNames prop to the DatePicker in the sidebar, allowing custom class names for styling.

  • Bug Fixes
    • Fixed issue where custom class names could not be set for the sidebar DatePicker.

weknowyourgame avatar May 30 '25 19:05 weknowyourgame

@weknowyourgame is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 30 '25 19:05 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/30/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (05/30/25)

1 label was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (05/30/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (06/23/25)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar May 30 '25 19:05 graphite-app[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jun 14 '25 00:06 github-actions[bot]

hey @weknowyourgame can you please share the loom that the classes are being applied or not ? (you can check it on inspect tab)

Devanshusharma2005 avatar Jun 15 '25 09:06 Devanshusharma2005

Hey @Devanshusharma2005 Sorry for replying so late completely missed your comment

here's a demo video:

https://github.com/user-attachments/assets/f810b688-c0cb-4901-b15a-6dffa8242b69

weknowyourgame avatar Jun 22 '25 17:06 weknowyourgame

E2E results are ready!

github-actions[bot] avatar Jun 23 '25 04:06 github-actions[bot]

@weknowyourgame can you pls resolve merge conflicts?

kart1ka avatar Jul 03 '25 05:07 kart1ka

Hey @kart1ka I think #21670 got merged which addresses the same issue as #21516

Should I close my PR since the issue is resolved?

weknowyourgame avatar Jul 04 '25 21:07 weknowyourgame

Yes @weknowyourgame. Thanks for your work

anikdhabal avatar Jul 07 '25 17:07 anikdhabal